Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in CI #54

Merged
merged 1 commit into from
Aug 15, 2021
Merged

Run tests in CI #54

merged 1 commit into from
Aug 15, 2021

Conversation

muchzill4
Copy link
Contributor

From what I gather "ensure_installed" does an async install, which makes tests run before the parsers are available. This works around that by using TSInstallSync.

Parser diffing happens, so that you're not prompted to reinstall a parser that's already available.

Additionally, I've hit a bug in nvim/plenary, where output produced by TSInstall* kabooms the test run:

nvim: /build/neovim-0bOHCD/neovim-0.5.0+ubuntu2+git202108111755-7d2233fad-d569569c9/src/nvim/message.c:2284: msg_scroll_flush: Assertion `pos_delta >= 0' failed.

It perhaps lacks the coconut oiliness, but seems to work, so.. 🤷.

@ThePrimeagen
Copy link
Owner

I love you and you deserve an award

@ThePrimeagen
Copy link
Owner

ThePrimeagen commented Aug 14, 2021

If this works, could you please rebase and i'll merge? (squash them)

@muchzill4
Copy link
Contributor Author

muchzill4 commented Aug 14, 2021

S Q U A S H E D 🫓

I would've thought there's a repo setting where you can enable squash merges, however I can't seem to find it on my fork, so perhaps not? 🤷

@ThePrimeagen ThePrimeagen merged commit e55f2bf into ThePrimeagen:master Aug 15, 2021
@muchzill4 muchzill4 deleted the ci-tests branch August 16, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants